Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Convert shortlist string to list #330

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

mike-sul
Copy link
Contributor

@mike-sul mike-sul commented Mar 22, 2024

  • Convert the comma-separated list of apps represented as a string and provided as an input parameter to a list of string.

  • Ignore any error that occurs during checking if apps were fetched before and let the image preloading functionality fetch apps from scratch.

@mike-sul mike-sul requested a review from doanac March 22, 2024 21:54
- Convert the comma-separated list of apps represented as a string and
  provided as an input parameter to a list of string.

Signed-off-by: Mike Sul <[email protected]>
If there is an error or exception occurs during checking whether
apps were fetched before then ignore it and let the assemble do its own
app fetching.

Signed-off-by: Mike Sul <[email protected]>
@mike-sul mike-sul force-pushed the fix/app-shortlist-is-list branch from 8767f3a to be2167a Compare March 25, 2024 10:19
@mike-sul mike-sul merged commit 5682dd5 into master Mar 25, 2024
2 checks passed
@mike-sul mike-sul deleted the fix/app-shortlist-is-list branch March 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants